[lxc-devel] [PATCH 1/4] Add missing 'extern' keyword to functions defined in cgroup.h

Christian Seiler christian at iwakd.de
Fri Feb 3 15:39:40 UTC 2012


Hi,

> Note that "extern" keyword on function declarations has no
> effect whatsoever.

Yes, but I personally think it's good practice to always put it there,
since it doesn't cause any harm either, because otherwise one may
forget the keyword with variables, where it really matters. Also, lxc
uses 'extern' throughout the rest of the code-base, so I see this part
of my patch as just harmonizing the file with coding standards of the
rest of the project.

Regards,
Christian





More information about the lxc-devel mailing list