[lxc-devel] [PATCH 2/2] templates: use hardlink detection in rsync

Dwight Engen dwight.engen at oracle.com
Mon Dec 3 17:40:42 UTC 2012


On Mon, 3 Dec 2012 10:47:26 -0600
Serge Hallyn <serge.hallyn at canonical.com> wrote:

> Quoting Dwight Engen (dwight.engen at oracle.com):
> > On Mon, 3 Dec 2012 10:04:13 -0600
> > Serge Hallyn <serge.hallyn at canonical.com> wrote:
> > 
> > > However one question is:  is -H ubiquitous?
> > 
> > I'm wondering why we don't just use the cp -a? It seems like cp is
> > far more likely to be installed than rsync? rootfs_path probably
> > doesn't already exist so it not like rsync is going to be faster?
> 
> The one advantage to me was that 'rsync -va /x/ /y' does the right
> thing whether or not /y already exists or not.  cp -a does not.  This
> just left the code tidier.
> 
> Is there a nicer clean one-line idiom to do that with cp?

I think cp -aT does what we want. You might want to add -u also.





More information about the lxc-devel mailing list