[lxc-devel] [PATCH] lxc-init: kill odd signal mask manipulation

Greg Kurz gkurz at fr.ibm.com
Tue Oct 18 13:38:18 UTC 2011


These lines appeared with commit 6f0a4200 and appear to be
wrong like Matt Hesley pointed in:

http://sourceforge.net/mailarchive/message.php?msg_id=28215685

Moreover, when looking at the signal handler:

static int was_interrupted = 0;

void interrupt_handler(int sig)
{
	if (!was_interrupted)
		was_interrupted = sig;
}

I don't think we need to mess around with SIGILL,
SIGSEGV and SIGBUS.

Signed-off-by: Greg Kurz <gkurz at fr.ibm.com>
---

 src/lxc/lxc_init.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/src/lxc/lxc_init.c b/src/lxc/lxc_init.c
index a534b51..819194a 100644
--- a/src/lxc/lxc_init.c
+++ b/src/lxc/lxc_init.c
@@ -101,9 +101,6 @@ int main(int argc, char *argv[])
 		struct sigaction act;
 
 		sigfillset(&act.sa_mask);
-		sigdelset(&mask, SIGILL);
-		sigdelset(&mask, SIGSEGV);
-		sigdelset(&mask, SIGBUS);
 		act.sa_flags = 0;
 		act.sa_handler = interrupt_handler;
 		sigaction(i, &act, NULL);





More information about the lxc-devel mailing list