[lxc-devel] [PATCH 2/2] lxc: use -iquote instead of -I

[Greg Kurz]

On Fri, 2011-11-04 at 11:18 +0100, Cedric Le Goater wrote:
> On 11/03/2011 05:41 PM, Greg Kurz wrote:
> > To avoid name collisions between local and system header
> > files. For example, if you try to include the<pty.h>
> > system file, you end up including the one from lxc...
> 
> <utmp.h> is the one.
> 

Oops... of course it is. :)

> couldn't we just kill this header file which only contains one declaration
> for start.c ?
> 
> I'm not in favor of touching the automake internals for just one warning.
> 

I guess you're right... it's better to avoid header file name
collisions.

> C.
> 
> > Signed-off-by: Greg Kurz<gkurz at fr.ibm.com>
> > ---
> >
> >   src/lxc/Makefile.am |    7 ++++++-
> >   1 files changed, 6 insertions(+), 1 deletions(-)
> >
> > diff --git a/src/lxc/Makefile.am b/src/lxc/Makefile.am
> > index 4215a94..5be796d 100644
> > --- a/src/lxc/Makefile.am
> > +++ b/src/lxc/Makefile.am
> > @@ -53,7 +53,12 @@ liblxc_so_SOURCES = \
> >   	\
> >   	utmp.c utmp.h
> >
> > -AM_CFLAGS=-I$(top_srcdir)/src \
> > +DEFAULT_INCLUDES = \
> > +	-iquote $(builddir) \
> > +	-iquote $(srcdir) \
> > +	-iquote $(top_builddir)/src
> > +
> > +AM_CFLAGS = \
> >   	-DLXCROOTFSMOUNT=\"$(LXCROOTFSMOUNT)\" \
> >   	-DLXCPATH=\"$(LXCPATH)\" \
> >   	-DLXCINITDIR=\"$(LXCINITDIR)\"
> >
> >
> > ------------------------------------------------------------------------------
> > RSA(R) Conference 2012
> > Save $700 by Nov 18
> > Register now
> > http://p.sf.net/sfu/rsa-sfdev2dev1
> > _______________________________________________
> > Lxc-devel mailing list
> > Lxc-devel at lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/lxc-devel
> >
> 

-- 
Gregory Kurz                                     gkurz at fr.ibm.com
Software Engineer @ IBM/Meiosys                  http://www.ibm.com
Tel +33 (0)534 638 479                           Fax +33 (0)561 400 420

"Anarchy is about taking complete responsibility for yourself."
        Alan Moore.