[lxc-devel] [PATCH 0/3] The poor man's attach

Greg Kurz gkurz at fr.ibm.com
Thu Nov 3 16:41:03 UTC 2011


On Thu, 2011-11-03 at 14:24 +0100, Cedric Le Goater wrote:
> For a reason I don't fully understand, src/lxc/pty.h gets included
> > instead of /usr/include/pty.h... hence the warning.
> 
> src/lxc/pty.h comes with these include options:
> 
>         DEFAULT_INCLUDES = -I. -I$(srcdir) -I$(top_builddir)/src
>   
> automake manages this part. I don't know if if can be changed.
> 

A solution to is to use the -iquote gcc option and to override
DEFAULT_INCLUDES. Some cleaning needs to be done first for
this to work: many local headers are incorrectly included with
the <> notation.

With the following patches, I managed to build inside and outside
the source tree. No more collisions with system headers.

Daniel, plz tell me if you want me to repost a full serie ?

Cheers.

---

Greg Kurz (2):
      lxc: use -iquote instead of -I
      lxc: fix erroneous includes


 src/lxc/Makefile.am |    7 ++++++-
 src/lxc/genl.c      |    5 +++--
 src/lxc/lxc_info.c  |    3 ++-
 src/lxc/mainloop.h  |    2 +-
 src/lxc/network.c   |    5 +++--
 src/lxc/nl.c        |    3 ++-
 src/lxc/restart.c   |    3 ++-
 src/lxc/rtnl.c      |    5 +++--
 src/lxc/start.c     |    5 +++--
 9 files changed, 25 insertions(+), 13 deletions(-)

-- 
Greg




More information about the lxc-devel mailing list