[lxc-devel] [PATCH] Fix some issues with inherited fd's

[Greg Kurz]

On Tue, 2011-08-23 at 13:37 +0400, Vladimir Smirnov wrote:
> Hello!
> 
> In attachment there are 2 patches to fix some issues with inherited
> fd's. Instead of just exiting with error, maybe it's better to set
> O_CLOEXEC flag.
> 

Hello Vladimir !

I agree that inherited descriptors probably deserve a cleverer approach
than what we have now.

Could you please resend these patches inlined in two separate mails so
that we can easily comment them ?

Cheers.

> 1-st patch changes lxc-init and lxc-attach to use clone instead of fork.
> Reason for it: clone permits to set custom flags, so you can call it
> without CLONE_FILES and all fd's with O_CLOEXEC flag won't be passed to
> child.
> 
> I'm not sure who and when should free child's stack. It seems to me that
> Linux handles it by itself, so stack is malloced, but not freed.
> 
> 2-nd patch changes lxc-start to set CLOEXEC instead of just returning
> with error.
> 
> It seems to me that fd's are not passed to lxc-init.
> 
> ------------------------------------------------------------------------------
> Get a FREE DOWNLOAD! and learn more about uberSVN rich system, 
> user administration capabilities and model configuration. Take 
> the hassle out of deploying and managing Subversion and the 
> tools developers use with it. http://p.sf.net/sfu/wandisco-d2d-2
> _______________________________________________
> Lxc-devel mailing list
> Lxc-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/lxc-devel

-- 
Gregory Kurz                                     gkurz at fr.ibm.com
Software Engineer @ IBM/Meiosys                  http://www.ibm.com
Tel +33 (0)534 638 479                           Fax +33 (0)561 400 420

"Anarchy is about taking complete responsibility for yourself."
        Alan Moore.