[lxc-devel] [PATCH] add lxc.network.veth.script configuration hook

[Daniel Lezcano]

On 10/07/2010 03:06 PM, Stefan Tomanek wrote:
> Dies schrieb Daniel Lezcano (daniel.lezcano at free.fr):
>
>    
>>    * lxc.network.script.pre:
>>
>> IMO,  it does not make sense because that means it is the host itself
>> which should be modified, so that fall under the host network
>> configuration umbrella =>  administrator job :P
>>      
> I cannot think of a fitting example, but I'd like to point at Debian's
> /etc/network/interfaces that has an even wider variety of hooks:
>
> pre-up
> up
> post-up
>
> pre-down
> down
> post-down
>
> And all of them are useful in one or another way :-)
>
>    
>>    * lxc.network.script.create
>>
>> Ok
>>
>>    * lxc.network.script.post
>>
>> Do you have an example of use case. Does it hurt if we 'merge' the
>> 'post' and 'create' hooks and put the 'create' right after the virtual
>> devices are created ? If it is done before, will fall in the same 'pre'
>> hook case, no ?
>>      
> The post script can be generic for all types of network configuration, while
> script.create is highly dependent on the type of network setup.
>    

Ok, I will play a bit with your patchset when it will be ready to check 
if there is no something we missed.

> PS: No need to CC every message to me, that way, mutt does not recognize
> the mailing list and makes responding awkward :-)
>    

Oh, sure.
I am so used to "reply-all", I can not guarantee that won't happen again :)

   -- Daniel