[lxc-devel] lxc_spawn() in lxc_restart()

[Sukadev Bhattiprolu]

Hi,

The following commit for restart-framework adds a call to lxc_spawn()
in lxc_restart(). lxc_spawn() creates a container and in the child
calls the restart plugin (which maps to app_restart() from USERCR)

	commit 196f1d54cef61534e6f98a47956cc87bffb6152e
	Author: Cedric Le Goater <clg at vnet.ibm.com>
	Date:   Tue Jun 1 11:44:44 2010 +0200

	    add restart framework

But if the entire container was checkpointed (as we do in LXC), the
checkpoint image already includes a container - So the restart logic
(in app_restart()) would restart the entire container.

With the above lxc_spawn(), the restarted container would be nested
insided the container created by lxc_spawn().

Is the lxc_spawn() in lxc_restart() required ?

If some set up needs to be done after app_restart() creates the new
container,  would adding a callback from app_restart() into LXC be
sufficient ?  i.e maybe this callback could do some/all of the steps
that do_start() does ?

Sukadev