[lxc-devel] [PATCH 1/3] rename struct lxc_netdev fields to match reality
Michael Tokarev
mjt at tls.msk.ru
Thu Nov 19 12:59:27 UTC 2009
Daniel Lezcano wrote:
> Michael Tokarev wrote:
>> struct lxc_netdev is used to hold information from cnfig file
>> about a network device/configuration. Make the fields of this
>> structure to be named similarily with the config file keywords,
>> namely:
>> s/ifname/link/ - host-side link for the device (bridge or eth0)
>> s/newname/name/ - container-side ifname
>> It is insane to have completely different names in config file
>> and in structure/variable names :)
>>
>> Signed-off-by: Michael Tokarev <mjt at tls.msk.ru>
>>
> I will apply the first and the fourth patch of the patchset.
The 2nd one (allow veth to be link-less) fixes null pointer deref
and is needed anyway if we want to let veth to be used in anything
but bridge. And the "pair" config parameter is needed too, if not
only to keep firewall rules and accounting working.
Thanks!
/mjt
More information about the lxc-devel
mailing list