[lxc-devel] lxc-console: batched read

Andrian Nord nightnord at gmail.com
Sat Nov 14 15:27:34 UTC 2009


On Sat, Nov 14, 2009 at 04:22:27PM +0300, Michael Tokarev wrote:
> Currently, lxc-console is quite too slow, because
> it is doing I/O one char at a time.  For input,
> which most likely goes from keyboard, it is not a
> problem really.  But for output (from container)
> it is quite time-consuming and slow.
> 
> Instead of reading one-char-at-a-time, let's read
> buffer-at-a-time.  The attached patch does just that.
> 
> Thanks!
> 
> /mjt

Probably you shoud read CONTRIBUTING file inside source tree ;)

About patch - try to not ignore warnings. 'int r =' inside of code it
something that violates, as far as I rember, used standart




More information about the lxc-devel mailing list