[lxc-devel] [PATCH 1/2] Add lxc.network.mtu configuration

Daniel Lezcano dlezcano at fr.ibm.com
Sun Mar 22 22:04:53 UTC 2009


Ryousei Takano wrote:
> Hi Daniel,
> 
> On Sun, Mar 22, 2009 at 7:46 AM, Daniel Lezcano <dlezcano at fr.ibm.com> wrote:
>> Ryousei Takano wrote:
>>> Hi Daniel,
>>>
>>> On Fri, Mar 20, 2009 at 7:27 PM, Daniel Lezcano <dlezcano at fr.ibm.com>
>>> wrote:
>>>
>>> [snip]
>>>
>>>
>>>> Otherwise the patch looks good. I tried to apply it but I got the error:
>>>>
>>>> Applying patch add-lxc.network.mtu-configuration.patch
>>>> patching file src/lxc/lxc_conf.c
>>>> patch: **** malformed patch at line 123: *directory, const char *file,
>>>> pid_t
>>>> pid)
>>>>
>>>> I tried with git-am and with a specific script to extract patches from
>>>> the
>>>> emails and I got the same error.
>>>>
>>>>
>>> I am sorry.  I cut and pasted my patch into gmail. It may be a folding
>>> failure.
>>> I reset my patch from another account.
>>>
>> It looks like there is the same problem. Maybe the culprit is the copy-paste
>> which adds spurious characters.
>> Can you try to send the patch in attachment, please ?
>>
> Please check another post from takano-ryousei at aist.go.jp, whose title is
> "[PATCH v2] Add lxc.network.mtu configuration (resend)."

Oh, ok. I thought I took this one :)
It applied without problem.

I played a bit with the patch and noticed the mtu is only set for one 
side of the veth, the one attached to the bridge, so I wrote a patch on 
top of your patch to set both side and applied both patches in the git 
tree. Maybe, that will increase the throughput performances a little more.

Thanks for your patch.
   -- Daniel




More information about the lxc-devel mailing list