[lxc-devel] [lxc/lxc] 016029: start: remove procfs pidfd support

Mon Mar 2 10:03:44 UTC 2020

  Branch: refs/heads/stable-3.0
  Home:   https://github.com/lxc/lxc
  Commit: 016029499d82166df89189c29fad5dbaa12fe8e9
      https://github.com/lxc/lxc/commit/016029499d82166df89189c29fad5dbaa12fe8e9
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-01-22 (Wed, 22 Jan 2020)

  Changed paths:
    M src/lxc/start.c
    M src/lxc/start.h

  Log Message:
  -----------
  start: remove procfs pidfd support

We'll only rely on proper anon-inode based pidfd support in the future.
There's no good reason to use the procfs fallback. All the fancy features we
might want to use are only available with anon-inode pidfds.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 6cd33a153c41618b8cf51e8b7d3a5fa7e61612e8
      https://github.com/lxc/lxc/commit/6cd33a153c41618b8cf51e8b7d3a5fa7e61612e8
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-01-22 (Wed, 22 Jan 2020)

  Changed paths:
    M src/lxc/mainloop.c

  Log Message:
  -----------
  mainloop: add missing \n

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: b4b6291c7fc3602b10a05d541d80bb00d2e138bf
      https://github.com/lxc/lxc/commit/b4b6291c7fc3602b10a05d541d80bb00d2e138bf
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-01-22 (Wed, 22 Jan 2020)

  Changed paths:
    M src/tests/api_reboot.c

  Log Message:
  -----------
  tests: timeout after 60 seconds

That should be more than enough to reboot.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 83aa9509f0a8db6739aa13e9be2652b4092842c2
      https://github.com/lxc/lxc/commit/83aa9509f0a8db6739aa13e9be2652b4092842c2
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-01-22 (Wed, 22 Jan 2020)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: handle kernel header and kernel incompatability

We might e.g. be compiled in a container with old kernel headers. In this
scenario CLONE_PIDFD will work but pidfd_send_signal() might not be detected
because __NR_pidfd_send_signal is not defined because the kernel headers don't
match the kernel version.

This explains and fixes test-suite hangs on Jenkins I've recently debugged.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 096bf70cee191e41ea22ee72e81b8aca97bb456b
      https://github.com/lxc/lxc/commit/096bf70cee191e41ea22ee72e81b8aca97bb456b
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-03-02 (Mon, 02 Mar 2020)

  Changed paths:
    M src/lxc/network.c

  Log Message:
  -----------
  network: fix typ and formatting in comment

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 061cd51d98ec806f0cc98b64d5606aad642a228a
      https://github.com/lxc/lxc/commit/061cd51d98ec806f0cc98b64d5606aad642a228a
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-03-02 (Mon, 02 Mar 2020)

  Changed paths:
    M src/tests/api_reboot.c

  Log Message:
  -----------
  tests: log api reboot test failures

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 7a28653a4ca2c3000d49ffc171c97c9daca186e9
      https://github.com/lxc/lxc/commit/7a28653a4ca2c3000d49ffc171c97c9daca186e9
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-03-02 (Mon, 02 Mar 2020)

  Changed paths:
    M src/lxc/network.c

  Log Message:
  -----------
  network: fix network device removal

We can't delete by netdev->ifindex since that's the ifindex of the device in
the container, not on the host. The correct thing is done below.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 9db43281d0d929d10e52924b7b4d62860e3a91db
      https://github.com/lxc/lxc/commit/9db43281d0d929d10e52924b7b4d62860e3a91db
  Author: LiFeng <lifeng68 at huawei.com>
  Date:   2020-03-02 (Mon, 02 Mar 2020)

  Changed paths:
    M src/lxc/cgroups/cgroup.c

  Log Message:
  -----------
  cgroup.c: fix memory leak at cgroup init failed

Signed-off-by: LiFeng <lifeng68 at huawei.com>

  Commit: 3de45bf62d40935afca59c573a7c2a103ee04042
      https://github.com/lxc/lxc/commit/3de45bf62d40935afca59c573a7c2a103ee04042
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-03-02 (Mon, 02 Mar 2020)

  Changed paths:
    M src/tests/api_reboot.c

  Log Message:
  -----------
  test: increase timeout for api reboot tests

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 183bda09237f4923c91ec3a567b1cfe2c77f6dea
      https://github.com/lxc/lxc/commit/183bda09237f4923c91ec3a567b1cfe2c77f6dea
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-03-02 (Mon, 02 Mar 2020)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: fix container killing logic

We need to account for the case where pidfd's are not supported by the kernel
in question.

Closes: #3254
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 834e11b633a98ccf30dc87e9c0fa207087a6b4c6
      https://github.com/lxc/lxc/commit/834e11b633a98ccf30dc87e9c0fa207087a6b4c6
  Author: Kirill Petrov <kspetrov at avito.ru>
  Date:   2020-03-02 (Mon, 02 Mar 2020)

  Changed paths:
    M configure.ac

  Log Message:
  -----------
  cgroups: fix default cgroup pattern

Signed-off-by: Kirill Petrov <yakutskkirill at mail.ru>

  Commit: f50520d5bc3c603377002e01678bbd12c5d00397
      https://github.com/lxc/lxc/commit/f50520d5bc3c603377002e01678bbd12c5d00397
  Author: Maximilian Blenk <Maximilian.Blenk at bmw.de>
  Date:   2020-03-02 (Mon, 02 Mar 2020)

  Changed paths:
    M src/lxc/confile.c

  Log Message:
  -----------
  container.conf: Fix off by 2 in option parsing

This commit fixes a off by 2 in config option parsing
(due to missing parenthesis). The error occurs if for instance
lxc.net.0.type is parsed. In that case, the .0 is removed from the
string. However, due to the missing parenthesis, the null terminating
character is off by two which means the modified config option would
be lxc.net.typepe instead of lxc.net.type.

Signed-off-by: Maximilian Blenk <Maximilian.Blenk at bmw.de>

  Commit: a4922b6193d028f3b89d0eb36f4908c017937882
      https://github.com/lxc/lxc/commit/a4922b6193d028f3b89d0eb36f4908c017937882
  Author: Maximilian Blenk <Maximilian.Blenk at bmw.de>
  Date:   2020-03-02 (Mon, 02 Mar 2020)

  Changed paths:
    M src/lxc/confile.c

  Log Message:
  -----------
  container.conf: Document that order is important in config_jump_table

Add a comment that documents that more specific options of a
namespace have to be added above more generic options in
config_jump_table.

Signed-off-by: Maximilian Blenk <Maximilian.Blenk at bmw.de>

  Commit: 8ecd7f2fa168fc4d06712d91f3dec42468111382
      https://github.com/lxc/lxc/commit/8ecd7f2fa168fc4d06712d91f3dec42468111382
  Author: Tycho Andersen <tycho at tycho.ws>
  Date:   2020-03-02 (Mon, 02 Mar 2020)

  Changed paths:
    M src/lxc/lxclock.c

  Log Message:
  -----------
  lxclock: fix a small memory leak

if (!name), we allocate an unnamed semaphore, but if we then fail to
allocate/create the lock, we don't free this semaphore, and we just leak
it.

Signed-off-by: Tycho Andersen <tycho at tycho.ws>

  Commit: bb39982059551c8c4e0108525f4d66a5d383b8d4
      https://github.com/lxc/lxc/commit/bb39982059551c8c4e0108525f4d66a5d383b8d4
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-03-02 (Mon, 02 Mar 2020)

  Changed paths:
    M src/lxc/attach.c
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/lxccontainer.c
    M src/lxc/start.c
    M src/lxc/storage/btrfs.c
    M src/lxc/storage/storage_utils.c

  Log Message:
  -----------
  tree-wide: improve setgroups() dropping

Drop groups before we change to userns root.

Reported-by: Teddy Reed <teddy.reed at gmail.com>
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 82187edaa7c47a30f9ddccc3bb52f0431f0ba380
      https://github.com/lxc/lxc/commit/82187edaa7c47a30f9ddccc3bb52f0431f0ba380
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-03-02 (Mon, 02 Mar 2020)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/cgroups/cgroup.c
    M src/lxc/cgroups/cgroup.h

  Log Message:
  -----------
  cgroups: remove unused method and cleanup cgroup_exit()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 33fb2e3d4f3efafcee57b5c63bc316087463f459
      https://github.com/lxc/lxc/commit/33fb2e3d4f3efafcee57b5c63bc316087463f459
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-03-02 (Mon, 02 Mar 2020)

  Changed paths:
    M configure.ac
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/initutils.c

  Log Message:
  -----------
  cgroups: honor lxc.cgroup.pattern if set explicitly

Link: https://discuss.linuxcontainers.org/t/lxc-cgroup-pattern-is-not-being-honored
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 21560b71ea5c6b0ed9593b9f586cf071cdc147a5
      https://github.com/lxc/lxc/commit/21560b71ea5c6b0ed9593b9f586cf071cdc147a5
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-03-02 (Mon, 02 Mar 2020)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/cgroups/cgroup.h
    M src/lxc/initutils.c

  Log Message:
  -----------
  cgroups: honor lxc.cgroup.pattern if set explicitly II

Link: https://discuss.linuxcontainers.org/t/lxc-cgroup-pattern-is-not-being-honored
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 2c5c780762981a5cfe699670c91397e29f6f6516
      https://github.com/lxc/lxc/commit/2c5c780762981a5cfe699670c91397e29f6f6516
  Author: Fabrice Fontaine <fontaine.fabrice at gmail.com>
  Date:   2020-03-02 (Mon, 02 Mar 2020)

  Changed paths:
    M src/lxc/raw_syscalls.c

  Log Message:
  -----------
  src/lxc/raw_syscalls.c: fix sparc assembly

Build of lxc 3.2.1 fails with ultrasparc on:

raw_syscalls.c: In function ‘lxc_raw_clone’:
raw_syscalls.c:66:3: error: invalid 'asm': invalid operand output code
   asm volatile(
   ^~~

Issue has been added with commit
b52e8e68a61866da2af86e85905ec850f8a8b7fc which added %g1 instead of %%g1

Fixes:
 - http://autobuild.buildroot.org/results/17c2319850f02f24da6fbef9656c07f86fdc5a3a

Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>

Compare: https://github.com/lxc/lxc/compare/31e6fdb41ea8...2c5c78076298