[lxc-devel] [lxc/lxc] b44c0a: coverity: #1426029

Wed Dec 13 18:26:33 UTC 2017

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: b44c0a678797e965f731b3e2451d42c319e4a265
      https://github.com/lxc/lxc/commit/b44c0a678797e965f731b3e2451d42c319e4a265
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-11 (Mon, 11 Dec 2017)

  Changed paths:
    M src/lxc/storage/overlay.c

  Log Message:
  -----------
  coverity: #1426029

fix use after free

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 29f133bc330ef59e9f0951c04c9789e4013eb262
      https://github.com/lxc/lxc/commit/29f133bc330ef59e9f0951c04c9789e4013eb262
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-11 (Mon, 11 Dec 2017)

  Changed paths:
    M src/lxc/af_unix.c

  Log Message:
  -----------
  coverity: #1425893

used calculated string length when copying into buffer

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: edeb1836bac992f1a6c19a0810fc8274c3de542f
      https://github.com/lxc/lxc/commit/edeb1836bac992f1a6c19a0810fc8274c3de542f
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-11 (Mon, 11 Dec 2017)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  coverity: #1425886

free allocated memory

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 7fd3d418107fc8312b5c60820720b794cc322726
      https://github.com/lxc/lxc/commit/7fd3d418107fc8312b5c60820720b794cc322726
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-11 (Mon, 11 Dec 2017)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  coverity: #1428855

remove logically dead code

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 8810408c6bf6cf03134938a86f63c5d54b9bcd8c
      https://github.com/lxc/lxc/commit/8810408c6bf6cf03134938a86f63c5d54b9bcd8c
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-11 (Mon, 11 Dec 2017)

  Changed paths:
    M src/lxc/storage/storage_utils.c

  Log Message:
  -----------
  coverity: #1425884

free allocated memory

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 3151d4e2d8207aa6d0d64b44e5a5921b39a67c43
      https://github.com/lxc/lxc/commit/3151d4e2d8207aa6d0d64b44e5a5921b39a67c43
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-11 (Mon, 11 Dec 2017)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  coverity: #1425883

ensure \0-termination

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: bc9724f76c07c7bbaf8881d32969b9585671013e
      https://github.com/lxc/lxc/commit/bc9724f76c07c7bbaf8881d32969b9585671013e
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-11 (Mon, 11 Dec 2017)

  Changed paths:
    M src/lxc/console.c
    M src/lxc/tools/lxc_attach.c

  Log Message:
  -----------
  coverity: #1425879

do not double close file descriptor

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: de429548c46d9b668388777198715853be6ae46d
      https://github.com/lxc/lxc/commit/de429548c46d9b668388777198715853be6ae46d
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-12 (Tue, 12 Dec 2017)

  Changed paths:
    M src/lxc/tools/lxc_top.c

  Log Message:
  -----------
  coverity: #1425870

check snprintf() return value

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 3ca108148be86db02bfbcc71cbe4ae46091fc930
      https://github.com/lxc/lxc/commit/3ca108148be86db02bfbcc71cbe4ae46091fc930
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-12 (Tue, 12 Dec 2017)

  Changed paths:
    M src/lxc/lxc_user_nic.c

  Log Message:
  -----------
  coverity: #1425869

do not unmap prematurely

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: d6d979bc2b5e1927d281e10419f5b0710c7e78c3
      https://github.com/lxc/lxc/commit/d6d979bc2b5e1927d281e10419f5b0710c7e78c3
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-12 (Tue, 12 Dec 2017)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  coverity: #1425867

do not pass NULL pointer to chdir()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 62de1db6ef2cca8671c9eb34dbe220a2189d1dd0
      https://github.com/lxc/lxc/commit/62de1db6ef2cca8671c9eb34dbe220a2189d1dd0
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-12 (Tue, 12 Dec 2017)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  coverity: #1425866

free allocated memory

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 6a0019fa97d73290ef8dfe508da8da766a19d940
      https://github.com/lxc/lxc/commit/6a0019fa97d73290ef8dfe508da8da766a19d940
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-12 (Tue, 12 Dec 2017)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  coverity: #1425863

remove logically dead code

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 41784e4ee493b52f3ade94fe40cd66eee4b5430e
      https://github.com/lxc/lxc/commit/41784e4ee493b52f3ade94fe40cd66eee4b5430e
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-12 (Tue, 12 Dec 2017)

  Changed paths:
    M src/lxc/criu.c
    M src/lxc/start.c
    M src/lxc/start.h

  Log Message:
  -----------
  coverity: #1425862

initialize handler

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: f54f8d0b5808f03fcbdd4ce24b98ca4f23ef5f98
      https://github.com/lxc/lxc/commit/f54f8d0b5808f03fcbdd4ce24b98ca4f23ef5f98
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-12 (Tue, 12 Dec 2017)

  Changed paths:
    M src/lxc/confile.c

  Log Message:
  -----------
  coverity: #1425861

free allocated memory

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: d5590c8c70fd3dd817fcd9f4e93dffc08711d41c
      https://github.com/lxc/lxc/commit/d5590c8c70fd3dd817fcd9f4e93dffc08711d41c
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-12 (Tue, 12 Dec 2017)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  coverity: #1425860

remove logically dead code

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: e8eb39565a94be7b744b7d15538b52a40937c6a3
      https://github.com/lxc/lxc/commit/e8eb39565a94be7b744b7d15538b52a40937c6a3
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-12 (Tue, 12 Dec 2017)

  Changed paths:
    M src/lxc/utils.c

  Log Message:
  -----------
  coverity: #1425859

check return value of snprintf()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 0e4adc1a3383921a67c506b5d04b45b3add5d898
      https://github.com/lxc/lxc/commit/0e4adc1a3383921a67c506b5d04b45b3add5d898
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-12 (Tue, 12 Dec 2017)

  Changed paths:
    M src/lxc/criu.c

  Log Message:
  -----------
  coverity: #1425858

free allocated memory

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: a55f31bda279a36581eae84bb73c064ed101600e
      https://github.com/lxc/lxc/commit/a55f31bda279a36581eae84bb73c064ed101600e
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-12 (Tue, 12 Dec 2017)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  coverity: #1425857

remove logically dead code

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: a61b4e85846c9d87f24465f3023e9c5f620ee265
      https://github.com/lxc/lxc/commit/a61b4e85846c9d87f24465f3023e9c5f620ee265
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-12 (Tue, 12 Dec 2017)

  Changed paths:
    M src/lxc/storage/overlay.c

  Log Message:
  -----------
  coverity: #1426028

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 9e1329562b9f3be8d86e611c146895866d8a6d28
      https://github.com/lxc/lxc/commit/9e1329562b9f3be8d86e611c146895866d8a6d28
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-12 (Tue, 12 Dec 2017)

  Changed paths:
    M src/lxc/conf.h

  Log Message:
  -----------
  conf: non-functional changes

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 941ee1fe2a22767edbf399e73e4a33746af612fe
      https://github.com/lxc/lxc/commit/941ee1fe2a22767edbf399e73e4a33746af612fe
  Author: Stéphane Graber <stgraber at stgraber.org>
  Date:   2017-12-13 (Wed, 13 Dec 2017)

  Changed paths:
    M src/lxc/af_unix.c
    M src/lxc/attach.c
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/conf.h
    M src/lxc/confile.c
    M src/lxc/console.c
    M src/lxc/criu.c
    M src/lxc/lxc_user_nic.c
    M src/lxc/lxccontainer.c
    M src/lxc/start.c
    M src/lxc/start.h
    M src/lxc/storage/overlay.c
    M src/lxc/storage/storage_utils.c
    M src/lxc/tools/lxc_attach.c
    M src/lxc/tools/lxc_top.c
    M src/lxc/utils.c

  Log Message:
  -----------
  Merge pull request #2017 from brauner/generic/patch_testing

coverity: bugfixes


Compare: https://github.com/lxc/lxc/compare/352e79d458b6...941ee1fe2a22