[lxc-devel] [PATCH 0/2] Create random workdir for overlay mounts

[Serge Hallyn]

Quoting Christian Brauner (christianvanbrauner at gmail.com):
> - When no explicit workdir is given we simply create a random workdir using
>   mkdtemp().
> - The temporary workdir is not removed when the container stops as it is not
>   obvious to me at this point how to do this cleanly. This means that it is left
>   to the user to clean up old random workdirs. I don't know if this is
>   considered a dealbreaker for anyone. If someone has a nice idea how to remove
>   the temporary workdirs (Serge?) do tell.

Hm.  Sorry, that's no good, I'm glad you caught that.  We can't leave
$number_of_runs * $number_of_overlays directories sitting around.
We could just use workdir.$(echo $target | tr / _)  so we can reuse
it?


> - Replace 4096 with LINELEN.
> - Take the chance to avoid code duplication in mount_entry_create_overlay_dirs()
>   and mount_entry_create_aufs_dirs().
> 
> Christian Brauner (2):
>   Simplify function
>   Create random workdir for overlay mounts
> 
>  src/lxc/conf.c | 45 ++++++++++++++++++++++++++++++---------------
>  1 file changed, 30 insertions(+), 15 deletions(-)
> 
> -- 
> 2.6.2
> 
> _______________________________________________
> lxc-devel mailing list
> lxc-devel at lists.linuxcontainers.org
> http://lists.linuxcontainers.org/listinfo/lxc-devel