[lxc-devel] [PATCH] don't compare unsigned values as negative ones
Tycho Andersen
tycho.andersen at canonical.com
Mon Apr 13 22:43:30 UTC 2015
Instead, check that the result is larger than its parts.
Signed-off-by: Tycho Andersen <tycho.andersen at canonical.com>
---
src/lxc/utils.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/lxc/utils.c b/src/lxc/utils.c
index 084b556..fe71e9a 100644
--- a/src/lxc/utils.c
+++ b/src/lxc/utils.c
@@ -1645,12 +1645,13 @@ int setproctitle(char *title)
env_start = env_end;
}
+ arg_end = arg_start + len;
+
/* check overflow */
- if (arg_start + len < 0) {
+ if (arg_end < len || arg_end < arg_start) {
return -1;
}
- arg_end = arg_start + len;
}
strcpy((char*)arg_start, title);
--
2.1.0
More information about the lxc-devel
mailing list