[lxc-devel] [PATCH] rename physical nics at shutdown
Serge Hallyn
serge.hallyn at canonical.com
Tue Dec 4 20:13:40 UTC 2012
Quoting Stéphane Graber (stgraber at ubuntu.com):
> > @@ -134,9 +133,12 @@ int lxc_execute(const char *name, char *const argv[], int quiet,
> > .argv = argv,
> > .quiet = quiet
> > };
> > + int ret;
> >
> > if (lxc_check_inherited(conf, -1))
> > return -1;
> >
> > - return __lxc_start(name, conf, &execute_start_ops, &args);
> > + ret = __lxc_start(name, conf, &execute_start_ops, &args);
> > +
> > + return ret;
> > }
>
> What's the reason for that bit? Looks to me as functionally identical.
D'oh - good catch. The reason for it was that at first I had the
rename_phys_on_shutdown in the lxc_start callers, not in __lxc_start
itself. I moved it right at the end, but forgot about this now-
unneeded bit.
thanks,
-serge
More information about the lxc-devel
mailing list